Add opcache instrumentation #440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeenaBansal20
force-pushed
the
feature/add-opcache-instrumentation
branch
from
e3d01c3 to
bfdb728
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
=========================================
Coverage 81.90% 81.90%
Complexity 1988 1988
=========================================
Files 137 137
Lines 8096 8096
=========================================
Hits 6631 6631
Misses 1465 1465 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
HeenaBansal20
force-pushed
the
feature/add-opcache-instrumentation
branch
2 times, most recently
from
7568b33 to
d4b484e
Compare
HeenaBansal20
force-pushed
the
feature/add-opcache-instrumentation
branch
from
45eb208 to
8bb376b
Compare
|
@brettmc , GitHub actions is not triggering CI for Opcache project , However I am able to run it locally. |
brettmc
reviewed
Sep 17, 2025
| } | ||
|
|
||
| if (extension_loaded('opentelemetry') === false) { | ||
| trigger_error('The opentelemetry extension must be loaded in order to autoload the OpenTelemetry IO auto-instrumentation', E_USER_WARNING); |
There was a problem hiding this comment.
Suggested change
| trigger_error('The opentelemetry extension must be loaded in order to autoload the OpenTelemetry IO auto-instrumentation', E_USER_WARNING); | |
| trigger_error('The opentelemetry extension must be loaded in order to autoload the OpenTelemetry opcache auto-instrumentation', E_USER_WARNING); |
|
|
||
| // Register our own shutdown function to capture OPcache metrics | ||
| // register_shutdown_function([self::class, 'captureMetricsOnShutdown']); | ||
| register_shutdown_function('OpenTelemetry\Contrib\Instrumentation\opcache\opcacheInstrumentation::addOpcacheMetricsToRootSpan'); |
There was a problem hiding this comment.
does this actually work? there's no guarantee that there is an active span during shutdown (I feel it's likely that there is not one), and also if there was an active span there's no guarantee that it's the root span. We do have an API method that would help, LocalRootSpan::current() however I think you need to re-think when this runs.
Perhaps a completely different approach where it emits metrics rather than attaching metric-like values to a span? You could do it with async/observable instruments.
There was a problem hiding this comment.
@brettmc , yeah I think you are right. we can take this up as a completely different way it emits metrics than span attributes.
I'll rework on this PR.
Thanks for the suggestion.
| php-version: 8.1 | ||
| - project: 'Instrumentation/PostgreSql' | ||
| php-version: 8.1 | ||
| - project: 'Instrumentation/Opcache' |
There was a problem hiding this comment.
I think this line excludes all versions. Since you're not actually hooking methods, you can just remove this line since it should work against 8.1
Suggested change
| - project: 'Instrumentation/Opcache' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds opcache instrumentation.